Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare rand_core 0.6.0 #1072

Merged
merged 5 commits into from
Dec 14, 2020
Merged

Prepare rand_core 0.6.0 #1072

merged 5 commits into from
Dec 14, 2020

Conversation

dhardy
Copy link
Member

@dhardy dhardy commented Dec 7, 2020 •
edited
Loading

Unfinished:

  • rand_chacha
  • rand_hc
  • rand_pcg

rand_chacha: #1023 re-enabled a dependency on the simd feature of ppv-lite86 since at the time that wasn't enabled-by-default, but this should be fixed now: cryptocorrosion/cryptocorrosion#36. So I think we should remove this feature dependency again since it is deprecated.

@dhardy
Copy link
Member Author

dhardy commented Dec 7, 2020

Hmm, we could force a dependency on ppv-lite >= 0.2.10 to properly resolve the issue, or we could be lax and let cargo update do its thing (but inevitably some users will be left out). I'd prefer the stricter dependency requirement. CC @kazcw

@dhardy
Copy link
Member Author

dhardy commented Dec 7, 2020

I disabled the cargo deadlinks check since we can't fix those errors right now. See also rust-lang/rust#77200

Changelogs have today's date, but I'm not certain the release will happen today (esp. if review is required).

@dhardy dhardy requested a review from vks December 7, 2020 17:10
@kazcw
Copy link
Contributor

kazcw commented Dec 7, 2020

@dhardy Either approach to proactively removing the simd flag from the ppv-lite dependency could degrade the experience of some rand users. When I meant by deprecating the simd flag is that new code has no reason to use it, but it wouldn't hurt anything to leave it for continued compatibility without older versions of the crate.

@jyn514
Copy link

jyn514 commented Dec 7, 2020

@dhardy the deadlinks failure isn't related to rustdoc at all, it's deadlinks/cargo-deadlinks#120. You can ignore it for now with --ignore-fragments, which will still check the links exist, just not the URL fragments.

@jyn514
Copy link

jyn514 commented Dec 7, 2020

Also, FWIW you can simplify the build script by running cargo +nightly deadlinks -- --all-features --all instead of running cargo doc first. That will also respect doc = false if you have it set somewhere.

@dhardy
Copy link
Member Author

dhardy commented Dec 7, 2020

@kazcw I tested with ppv-lite86 0.2.9 and 0.2.10 and clearly the fix works. That said we've no reason to do this (until ppv-lite86 0.3) so I guess you're right that removing the change is better.

@jyn514 the link failure is real (from POV of rand_distr which is part of this repo), so I don't think it is that?

@jyn514
Copy link

jyn514 commented Dec 7, 2020

@dhardy this is the file I see for target/doc/rand/rng/trait.Rng.html:

<!DOCTYPE html>
<html lang="en">
<head>
    <meta http-equiv="refresh" content="0;URL=../../rand/trait.Rng.html">
</head>
<body>
    <p>Redirecting to <a href="../../rand/trait.Rng.html">../../rand/trait.Rng.html</a>...</p>
    <script>location.replace("../../rand/trait.Rng.html" + location.search + location.hash);</script>
</body>
</html>

What do you see? It exists, because the error reported is about a broken fragment, not a missing file.

@kazcw
Copy link
Contributor

kazcw commented Dec 7, 2020

@dhardy I have no doubt that 0.2.10 works correctly. I was referring to the cost to some users of forcing a dependency upgrade

@vks
Copy link
Collaborator

vks commented Dec 7, 2020

I was referring to the cost to some users of forcing a dependency upgrade

I'm not sure what the cost of upgrading from ppv-lite86 0.2.8 to 0.2.10 is. The difference is only some patch releases, so cargo update should be enough?

vks
vks reviewed Dec 7, 2020
View reviewed changes
rand_chacha/CHANGELOG.md Outdated
## [0.3.0] - 2020-12-07
- Bump `rand_core` version to 0.6.0
- Bump MSRV to 1.36 (#1011)
- Remove usage of deprecated feature "simd" of `ppv-lite86` (#979), revert
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit confusing. What exactly is reverted?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous change (removal of feature usage)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe write 'Use deprecated feature "simd" of ppv-lite86 for improved compatibility'?

@dhardy
Copy link
Member Author

dhardy commented Dec 8, 2020

@jyn514 aha... I didn't realise doc/rand_distr/struct.Uniform.html links to <a href="../rand/rng/trait.Rng.html#method.gen_range">. Thanks for the help.

dhardy added a commit to dhardy/rand that referenced this pull request Dec 8, 2020
@dhardy
cargo-deadlinks: ignore fragments
335842a 
These caused failures (see rust-random#1072)
@dhardy
Copy link
Member Author

dhardy commented Dec 8, 2020

Force update:

  • update dates
  • remove the change on ppv-lite86 dependency feature
  • use --ignore-fragments on cargo-deadlinks

@dhardy
Copy link
Member Author

dhardy commented Dec 8, 2020

So much for fixing up the Travis CI. We don't get much notice do we: https://www.reddit.com/r/programming/comments/k8v6u2/travis_ci_is_no_longer_providing_ci_minutes_for/

@PaulGrandperrin PaulGrandperrin mentioned this pull request Dec 11, 2020
Closed
vks
vks reviewed Dec 14, 2020
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
vks
vks approved these changes Dec 14, 2020
View reviewed changes
Copy link
Collaborator

@vks vks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dhardy
Copy link
Member Author

dhardy commented Dec 14, 2020

Yeah, but I want to rebase after porting CI. Travis dropped our jobs just before validating this one. 😒

@dhardy dhardy merged commit 98e220c into rust-random:master Dec 14, 2020
@dhardy
Copy link
Member Author

dhardy commented Dec 14, 2020

Published!

@sync-by-unito sync-by-unito bot mentioned this pull request Dec 15, 2020
Merged
@kevinlewi kevinlewi mentioned this pull request Dec 15, 2020
Closed
This was referenced Mar 12, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vks vks vks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhardy @kazcw @jyn514 @vks