Don't block in getrandom() detection #26
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Linux, we detect if
getrandom
is present by callinggetrandom
withan empty buffer and seeing if
ENOSYS
is returned. However, even withan empty buffer, this call will block unless we explicitly pass a flag.
This can be seen in the source for
getrandom
:https://elixir.bootlin.com/linux/v5.1.8/source/drivers/char/random.c#L2043
This change adds a boolean parameter to
syscall_getrandom
to controlthe blocking behavior. We now don't block in initialization, but do
block when actually reading random data.