travis: Update pinned dependancies #157
Conversation
Also, pin the version of rustc, so that nightly updates don't break our build. This means that we can add the nightlies back into the blocking set of tests. Update the Ubuntu version to 20.04 Don't run any cargo-web tests (upstream is broken) Signed-off-by: Joe Richey <[email protected]>
Signed-off-by: Joe Richey <[email protected]>
Signed-off-by: Joe Richey <[email protected]>
Signed-off-by: Joe Richey <[email protected]>
Signed-off-by: Joe Richey <[email protected]>
Cloud ABI [is now Tier 3](rust-lang/rust#75568), so its libstd is no longer distributed with Rust. Firefox testing is also disabled due to: rustwasm/wasm-bindgen#2261 Signed-off-by: Joe Richey <[email protected]>
Signed-off-by: Joe Richey <[email protected]>
.travis.yml
Outdated
| @@ -88,7 +91,7 @@ matrix: | |||
| - RUSTFLAGS='-C debuginfo=0' cargo test --target asmjs-unknown-emscripten | |||
|
|
|||
| - name: "Linux, nightly, docs" | |||
| rust: nightly | |||
| rust: nightly-2020-09-08 | |||
There was a problem hiding this comment.
I am not sure if it's a good idea to pin Nightly. Even if in future some change will break our build, I think it's better to find about it sooner than later.
There was a problem hiding this comment.
Would you want to mark all of the nightly builds as non-blocking then? We use nightly for:
- a Linux build
- a Mac build
- cross compiling
- All of our WASM targets
There was a problem hiding this comment.
I generally agree with this point though. I think we should move as much as we can out of the nightly tests into the stable tests. Then, mark all the stable tests as non-blocking.
EDIT: Note that we have blocking beta tests, so we should be able to catch anything super-bad before it hits stable.
There was a problem hiding this comment.
Did we have problems with nightly builds previously? If I had to chose, I would prefer making those jobs non-blocking.
There was a problem hiding this comment.
We did, a nightly didn't have some component we needed (rustfmt maybe, but that's already non-blocking).
I agree that we should have them be blocking, should be fixed now.
There was a problem hiding this comment.
There was a problem hiding this comment.
Looking at https://travis-ci.org/github/rust-random/getrandom/builds/714877349 and https://travis-ci.org/github/rust-random/getrandom/builds/724230064 they are monthly cron jobs
Signed-off-by: Joe Richey <[email protected]>
Also, pin the version of rustc, so that nightly updates don't break
our build. This means that we can add the nightlies back into the
blocking set of tests.
Move cloudabi to
cargo xbuildas it is now a Teir 3 targetDisable Firefox testing due to rustwasm/wasm-bindgen#2261
Signed-off-by: Joe Richey [email protected]