Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for cr4 control register #92

Closed
wants to merge 1 commit into from
Closed

Add support for cr4 control register #92

wants to merge 1 commit into from

Conversation

KarimAllah
Copy link
Contributor

No description provided.

phil-opp
phil-opp approved these changes Nov 2, 2019
View reviewed changes
Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request and sorry for the delay! Looks good to me.

I'm not sure what the problem with the CI is yet. I'll look into it and merge this PR after I found the issue.

@phil-opp
Copy link
Member

phil-opp commented Nov 2, 2019

I switched the CI to Github Actions in #93, now the automatic test suite should work again.

Let's try to merge this PR!

bors r+

bors bot added a commit that referenced this pull request Nov 2, 2019
@bors @KarimAllah
Merge #92
a70de95 
92: Add support for cr4 control register r=phil-opp a=KarimAllah



Co-authored-by: KarimAllah Ahmed <[email protected]>
@bors
Copy link
Contributor

bors bot commented Nov 2, 2019

Build failed

  • Check Formatting

@phil-opp
Copy link
Member

phil-opp commented Nov 2, 2019 •
edited
Loading

@KarimAllah Could you run cargo fmt the code?

@phil-opp
Copy link
Member

phil-opp commented Nov 2, 2019

Thanks! We also require documentation for all items, including the bitflags flags. Could you add a short sentance for each flag please?

@phil-opp
Copy link
Member

@KarimAllah Friendly ping :). Do you have the time to add a short comment for the individual flags? Then we would be ready to merge. If you don't have the time, please let me know! Then I'll try to write the comments myself when I have some time.

@phil-opp phil-opp mentioned this pull request Dec 13, 2019
Merged
@phil-opp
Copy link
Member

I added the missing documentation my self in #111, so that we can get this merged. Thanks again for the pull request @KarimAllah!

@phil-opp phil-opp closed this Dec 13, 2019
@phil-opp
Copy link
Member

(Closing in favor of #111)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-opp phil-opp phil-opp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KarimAllah @phil-opp