Make Mapper trait object safe by adding Self: Sized bounds on generic functions
#84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There were no objections in the last months, so I think we can merge this. bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 5, 2019
84: Make Mapper trait object safe by adding `Self: Sized` bounds on generic functions r=phil-opp a=phil-opp See #80 for more information I'm not quite sure whether this is a **breaking change**, but I think it is. 89: Add new UnsafePhysFrame type and use it in Mapper::map_to r=phil-opp a=phil-opp Fixes #88 This pull request adds a new `UnsafePhysFrame` type that wraps a `PhysFrame`. The type is unsafe to construct and the caller must guarantee that the frame is not mapped already. This type allows to make the `map_to` and `identity_map` methods of the `Mapper` trait safe. This PR also adjust the `FrameAllocator` to use the new type. This is a **breaking change**. Co-authored-by: Philipp Oppermann <[email protected]>
bors bot
added a commit
that referenced
this pull request
Dec 5, 2019
84: Make Mapper trait object safe by adding `Self: Sized` bounds on generic functions r=phil-opp a=phil-opp See #80 for more information I'm not quite sure whether this is a **breaking change**, but I think it is. 89: Add new UnsafePhysFrame type and use it in Mapper::map_to r=phil-opp a=phil-opp Fixes #88 This pull request adds a new `UnsafePhysFrame` type that wraps a `PhysFrame`. The type is unsafe to construct and the caller must guarantee that the frame is not mapped already. This type allows to make the `map_to` and `identity_map` methods of the `Mapper` trait safe. This PR also adjust the `FrameAllocator` to use the new type. This is a **breaking change**. Co-authored-by: Philipp Oppermann <[email protected]>
Timed out (retrying...) |
bors bot
added a commit
that referenced
this pull request
Dec 5, 2019
84: Make Mapper trait object safe by adding `Self: Sized` bounds on generic functions r=phil-opp a=phil-opp See #80 for more information I'm not quite sure whether this is a **breaking change**, but I think it is. Co-authored-by: Philipp Oppermann <[email protected]>
|
Seems like we have some problems with bors bors r- |
Canceled |
phil-opp
force-pushed
the
mapper-object-safety
branch
from
897a35f
to
ae11c57
Compare
phil-opp
added a commit
that referenced
this pull request
Dec 10, 2019
phil-opp
added a commit
that referenced
this pull request
Dec 10, 2019
phil-opp
force-pushed
the
mapper-object-safety
branch
from
e261f54
to
ef3c0f6
Compare
phil-opp
force-pushed
the
mapper-object-safety
branch
from
ef3c0f6
to
36b4d61
Compare
phil-opp
added a commit
that referenced
this pull request
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #80 for more information
I'm not quite sure whether this is a breaking change, but I think it is.