Typo fix in TaskStateSegment comment #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freax13
requested changes
Oct 20, 2024
| @@ -6,7 +6,7 @@ use core::mem::size_of; | |||
| /// In 64-bit mode the TSS holds information that is not | |||
| /// directly related to the task-switch mechanism, | |||
| /// but is used for finding kernel level stack | |||
| /// if interrupts arrive while in kernel mode. | |||
There was a problem hiding this comment.
Technically the comment is correct for both kernel and user mode. I'm guessing you are thinking of the privilege stack table which is relevant when an interrupt/exception occurs in user mode, but the TSS also contains the interrupt stack table which is also relevant in kernel mode. Can you please reword the comment?
mrjbom
force-pushed
the
master
branch
3 times, most recently
from
e2b05fc to
20a1bb0
Compare
|
@Freax13, now the description is the most accurate |
|
Could you please mention interrupts/exceptions in the comment? I feel that without this it may not be clear when stack switching might be useful. |
mrjbom
force-pushed
the
master
branch
2 times, most recently
from
390327e to
aca4e06
Compare
|
I think it's clear now |
Freax13
reviewed
Oct 21, 2024
Freax13
approved these changes
Oct 22, 2024
Co-authored-by: Tom Dohrmann <[email protected]>
Co-authored-by: Tom Dohrmann <[email protected]>
Co-authored-by: Tom Dohrmann <[email protected]>
|
I rebased this PR onto master to fix CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.