Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only enable instructions on x86_64 #483

Merged
merged 2 commits into from
Apr 28, 2024
Merged

Conversation

phil-opp
Copy link
Member

@phil-opp phil-opp commented Apr 28, 2024

A build on non-x86_64 platforms with the instructions feature enabled should not results in lots of inline assembly errors.

Implements option 3 described in #482 (comment).

Fixes the CI build error on macos-latest, which uses an ARM-based runner now.

@phil-opp phil-opp force-pushed the arch-specific-instructions branch 2 times, most recently from b97efc7 to 03eed51 Compare April 28, 2024 08:36
A build on non-x86_64 platforms with the `instructions` feature enabled should not results in lots of inline assembly errors.
@phil-opp phil-opp marked this pull request as ready for review April 28, 2024 08:41
@phil-opp phil-opp requested a review from Freax13 April 28, 2024 08:41
Copy link
Member

@Freax13 Freax13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@phil-opp phil-opp merged commit 051a18a into master Apr 28, 2024
13 checks passed
@phil-opp phil-opp deleted the arch-specific-instructions branch April 28, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants