Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused doc_cfg feature #408

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Remove unused doc_cfg feature #408

merged 1 commit into from
Mar 7, 2023

Conversation

phil-opp
Copy link
Member

@phil-opp phil-opp commented Mar 7, 2023

We used this unstable feature in the past for annotating nightly-only macros that require inline assembly: 17ca2b0. Now that inline assembly is stable, we don't use that feature anymore, so I think we can remove it.

Copy link
Member

@Freax13 Freax13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

Copy link
Contributor

@josephlr josephlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up

@phil-opp phil-opp merged commit 29f6c75 into master Mar 7, 2023
@phil-opp phil-opp deleted the remove-doc-cfg branch March 7, 2023 12:04
@Freax13 Freax13 mentioned this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants