Increase alginment for packed structures #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While both TaskStateSegment and DescriptorTablePointer can't have their normal C alignment due to their definition. However, this doesn't mean their alignment has to be `1`. This PR sets their alignment to be the max possible while still preserving their ABI definied structure. I added some tests to make sure there is not a regression. This can also result in more efficient code generation on platofrms without unalgined loads. https://rust.godbolt.org/z/EPbbMxeq1 Signed-off-by: Joe Richey <[email protected]>
Merged
Freax13
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While both TaskStateSegment and DescriptorTablePointer can't have their
normal C alignment due to their definition. However, this doesn't mean
their alignment has to be
1.This PR sets their alignment to be the max possible while still
preserving their ABI definied structure. I added some tests to make sure
there is not a regression.
This can also result in more efficient code generation on platofrms
without unalgined loads. https://rust.godbolt.org/z/EPbbMxeq1
Signed-off-by: Joe Richey [email protected]