Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User CET Register #349

Merged
merged 1 commit into from
Mar 19, 2022
Merged

User CET Register #349

merged 1 commit into from
Mar 19, 2022

Conversation

jarkkojs
Copy link
Contributor

@jarkkojs jarkkojs commented Mar 14, 2022

This embedded to some of SGX structures (at least SECS and REPORT), so that's I need to bring some support to x86_64 crate. Does not cover fields TRACKER but EB_LEG_BITMAP_BASE but:

  • They are not part of the settable flags.
  • They need to be encoded and decoded separately, i.e. in all cases need their own accessors

Actually SGX structures and encl* need only UCetFlags but it would have been crippled just to implement that structure without context.

@jarkkojs
Copy link
Contributor Author

There was one spurious change, which I removed.

@jarkkojs
Copy link
Contributor Author

Last two flags had "ENABLE" and "DISABLE" as prefix, unlike previous flags.

@jarkkojs jarkkojs changed the title feat(ucet) User CET Register Mar 14, 2022
Copy link
Member

@Freax13 Freax13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

src/registers/model_specific.rs Outdated Show resolved Hide resolved
src/registers/model_specific.rs Outdated Show resolved Hide resolved
src/registers/model_specific.rs Outdated Show resolved Hide resolved
src/registers/model_specific.rs Outdated Show resolved Hide resolved
src/registers/model_specific.rs Outdated Show resolved Hide resolved
src/registers/model_specific.rs Outdated Show resolved Hide resolved
src/registers/model_specific.rs Show resolved Hide resolved
src/registers/model_specific.rs Outdated Show resolved Hide resolved
src/registers/model_specific.rs Outdated Show resolved Hide resolved
@jarkkojs
Copy link
Contributor Author

OK, updated, I have for some reason cargo clippy broken in my desktop. It throws a pile of complains even for the master branch of this crate,and also every other crate that I'm working on :-( So I have to see what the CI says.

Copy link
Member

@Freax13 Freax13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments, then this is ready to get merged :)

src/registers/model_specific.rs Outdated Show resolved Hide resolved
src/registers/model_specific.rs Outdated Show resolved Hide resolved
src/registers/model_specific.rs Outdated Show resolved Hide resolved
Add support for IA32_U_CET and IA32_S_CET, which are used for Control flow
Execution Technology (CET) configuration.

Signed-off-by: Jarkko Sakkinen <[email protected]>
Copy link
Member

@Freax13 Freax13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@Freax13 Freax13 enabled auto-merge March 19, 2022 14:49
@jarkkojs
Copy link
Contributor Author

Thanks for the help :-)

@Freax13 Freax13 merged commit 8bec7be into rust-osdev:master Mar 19, 2022
@jarkkojs jarkkojs deleted the feat/ucet branch March 19, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants