Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make fields public #340

Merged
merged 1 commit into from
Feb 5, 2022
Merged

make fields public #340

merged 1 commit into from
Feb 5, 2022

Conversation

Freax13
Copy link
Member

@Freax13 Freax13 commented Feb 5, 2022

This pr makes the fields of the VirtAddrNotValid and PhysAddrNotValid error types public.

This was suggested by @phil-opp: #335 (comment).

@Freax13 Freax13 added the waiting-for-review Waiting for a review from the maintainers. label Feb 5, 2022
@Freax13 Freax13 requested a review from phil-opp February 5, 2022 11:13
@Freax13 Freax13 mentioned this pull request Feb 5, 2022
Merged
phil-opp
phil-opp approved these changes Feb 5, 2022
View reviewed changes
Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@phil-opp phil-opp merged commit 3d32678 into rust-osdev:master Feb 5, 2022
@Freax13 Freax13 deleted the expose-fields-in-errors branch February 5, 2022 15:52
phil-opp added a commit that referenced this pull request Mar 1, 2022
@phil-opp
Fix: VirtAddrNotValid and PhysAddrNotValid should contain the who…
b40eac1 
…le address

Not just the invalid higher bits. We made the internal fields public in #340, but fortunately we didn't release this change yet, so this fix is still non-breaking.
@phil-opp phil-opp mentioned this pull request Mar 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-opp phil-opp phil-opp approved these changes

Assignees
No one assigned
Labels
waiting-for-review Waiting for a review from the maintainers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Freax13 @phil-opp