Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: build error on the latest nightly (asm! import) #329

Merged
merged 4 commits into from
Dec 18, 2021
Merged

fix: build error on the latest nightly (asm! import) #329

merged 4 commits into from
Dec 18, 2021

Conversation

toku-sa-n
Copy link
Member

asm! is excluded from Prelude.

@toku-sa-n
fix: build error on the latest nightly
af206af 
`asm!` is excluded from Prelude.
Freax13
Freax13 requested changes Dec 16, 2021
View reviewed changes
Copy link
Member

@Freax13 Freax13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

src/registers/control.rs Outdated Show resolved Hide resolved
src/registers/model_specific.rs Outdated Show resolved Hide resolved
src/registers/rflags.rs Outdated Show resolved Hide resolved
src/registers/xcontrol.rs Outdated Show resolved Hide resolved
@Freax13
Copy link
Member

Freax13 commented Dec 16, 2021

I also saw that asm! will be stabilized in 1.59. We can probably remove the inline_asm and external_asm features once asm! is stabilized.

@toku-sa-n
Copy link
Member Author

All done.

@phil-opp
Move bootloader integration test to separate CI job
ae44fab 
We should not make this test part of the manditory test suite because the bootloader crate depends on x86_64 itself. Thus, some breaking changes require a two-phase update.
@phil-opp
Merge PR rust-osdev#330
449f6b9
@phil-opp phil-opp mentioned this pull request Dec 18, 2021
Merged
@phil-opp phil-opp merged commit 575de31 into rust-osdev:master Dec 18, 2021
@phil-opp phil-opp mentioned this pull request Dec 18, 2021
Merged
@toku-sa-n toku-sa-n deleted the fix_asm branch December 18, 2021 17:26
@phil-opp phil-opp changed the title fix: build error on the latest nightly fix: build error on the latest nightly (asm! import) Jan 8, 2022
@Freax13 Freax13 mentioned this pull request Jan 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Freax13 Freax13 Freax13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toku-sa-n @Freax13 @phil-opp