Move segment types into a new registers::segmentation
module
#309
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The segment types themselves and the related traits do not require the
instructions
feature, so I think that it makes sense to move them to the top-levelregisters
module. Theinstructions::segmentation
module still re-exports all the types, so this change should not break any code. I also moved theSegmentSelector
type from thegdt
module to the new module since it's more related to the segment registers than to the GDT.This should fix
cargo doc
errors reported in #307 since the segment types are now available even without theinstructions
feature. Some special handling was necessary for theGsBase
andKernelGsBase
types: They now use a#[cfg_attr(feature = "instructions", doc = "...")]
to append the link to theswap
method only when it is available.To ensure that we don't regress on this, I added
cargo doc --no-default-features
as a step in our CI script.Fixes #307