-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
software_interrupt: Add additional testing #260
Conversation
So we accidentally resetted the |
Signed-off-by: Joe Richey <[email protected]>
I just added the setting that prevents force pushing (after I realized my mistake in moving the EDIT: Looked though my Git history and this was definitely my bad. I force pushed the branch while trying to fix things with #259 (I had forgotten that |
@josephlr No worries, I just tried to understand what was going on.
Sure, we can try that if you have time for regular reviews. Not directly related, but I would also like to automate the release creation process through GitHub actions (e.g. use the GitHub Api to detect whether the current crate version is present on crates.io and do a |
Given that we're starting to use this crate more at work, I think I'll be able to commit more time here. Also, can anyone in the @rust-osdev org approve changes for this repo? I just enabled the settings and confirmed that I can no longer merge this PR without your approval.
I think that would be an optimal way to go about things, anything that makes the release process less painful is fine by me. |
Great to hear that! I would love to hear more about how you're using this crate. Anything you can talk about?
👍
Ok, cool. I try to look into this soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Followup to rust-osdev#259. Code previously merged as part of rust-osdev#227. Signed-off-by: Joe Richey <[email protected]>
Followup to rust-osdev#259. Code previously merged as part of rust-osdev#227. Signed-off-by: Joe Richey <[email protected]>
So I just realized we already had some of the changes in #259 merged as part of #227.
This PR adds the rest of the testing code. CC: @Freax13
Signed-off-by: Joe Richey [email protected]