Implement more fmt traits for addr types #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbeckwith
commented
Mar 27, 2021
dbeckwith
changed the title
|
The windows build failures seem unrelated to my changes. |
|
Looks good to me, thanks! The Windows build is currently broken because of a bug in QEMU, so it has nothing to do with this PR. |
phil-opp
added a commit
that referenced
this pull request
Mar 27, 2021
|
Published as v0.13.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor improvements for debug traits for the address types:
fmt::Binary,fmt::LowerHex,fmt::Octal,fmt::UpperHeximpls forVirtAddrfmt::Pointerimpls forVirtAddrandPhysAddrfmt::Formatter::debug_tuplein thefmt::Debugimpls so formatting flags are respected