Restructure the TranslateResult type and create separate Translate trait
#211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 28, 2020
phil-opp
force-pushed
the
translate-redesign
branch
from
86d7e31
to
274e3dc
Compare
This was referenced Dec 28, 2020
Merged
This was referenced Mar 17, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the design proposed in #150 (comment) and fixes #152.
This is a breaking change: The
MapperAllSizestrait no longer has any methods and is only kept for convenience. Thetranslateandtranslate_addrmethods are now available through a newTranslatetrait. TheTranslateResulttype was restructed to avoid repititions.