Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error on latest nightly #182

Merged
merged 1 commit into from
Sep 24, 2020

Conversation

toku-sa-n
Copy link
Member

Copy link
Contributor

@josephlr josephlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully we will reach a point where const_fn is split up enough that we won't have to depend on the blanket feature.

@josephlr
Copy link
Contributor

This passes locally for me, but the issue seems to be that the test framework builds with the old version of this crate, so the tests can never pass.

@josephlr
Copy link
Contributor

@phil-opp I don't have permissions to override the CI, otherwise I would merge this.

@phil-opp
Copy link
Member

Thank you!

The CI fails because the test framework depends on the bootloader crate, which itself has a dependency on an older x86_64 version. I don't think that we can resolve this without publishing new x86_64 and bootloader versions unfortunately, so let's merge and publish this even with failing CI. For the future we should try to remove this circular dependency if possible.

@phil-opp phil-opp changed the title Fix build error Fix build error on latest nightly Sep 24, 2020
@phil-opp phil-opp merged commit 4c17ce9 into rust-osdev:master Sep 24, 2020
phil-opp added a commit that referenced this pull request Sep 24, 2020
@phil-opp
Copy link
Member

Published as v0.12.1. I'll do the bootloader update next, to hopefully fix the CI again.

@toku-sa-n toku-sa-n deleted the fix_build_error branch September 24, 2020 07:24
@phil-opp
Copy link
Member

I published versions of the bootloader (in rust-osdev/bootloader#128) and uart_16550 crates and manually restarted the CI. Looks like everything is green again: https://github.com/rust-osdev/x86_64/runs/1159219587

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants