Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't pass small trivially copyable types by reference. #147

Merged
merged 1 commit into from
Apr 11, 2020
Merged

Don't pass small trivially copyable types by reference. #147

merged 1 commit into from
Apr 11, 2020

Conversation

m-ou-se
Copy link
Contributor

@m-ou-se m-ou-se commented Apr 11, 2020 •
edited by phil-opp
Loading

Edit(phil-opp): This is a breaking change.

phil-opp
phil-opp approved these changes Apr 11, 2020
View reviewed changes
Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@phil-opp phil-opp merged commit 7bf7b81 into rust-osdev:master Apr 11, 2020
phil-opp added a commit that referenced this pull request Apr 11, 2020
@phil-opp
Update changelog for #147
c21ffcb
@m-ou-se m-ou-se deleted the copy branch April 11, 2020 12:04
@phil-opp phil-opp mentioned this pull request Apr 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-opp phil-opp phil-opp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-ou-se @phil-opp