Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In VirtAddr::new_truncate, use shift instead of mul and div. #143

Merged
merged 1 commit into from
Apr 11, 2020
Merged

In VirtAddr::new_truncate, use shift instead of mul and div. #143

merged 1 commit into from
Apr 11, 2020

Conversation

m-ou-se
Copy link
Contributor

@m-ou-se m-ou-se commented Apr 11, 2020

The comment (my comment) said that shifts don't work in const fns, but it appears the comment was either wrong or outdated.

@m-ou-se
In VirtAddr::new_truncate, use shift instead of mul and div.
7841af1 
The comment (my comment) said that shifts don't work in const fns, but
it appears the comment was either wrong or outdated.
@phil-opp
Copy link
Member

Thanks!

@phil-opp phil-opp merged commit 1808cbe into rust-osdev:master Apr 11, 2020
@m-ou-se m-ou-se deleted the shift branch April 11, 2020 10:14
phil-opp added a commit that referenced this pull request Apr 11, 2020
@phil-opp
Update changelog for #143
dde6f2b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-ou-se @phil-opp