-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable usage with non-nightly rust #127
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the PR! The changes mostly look good to me, apart from the comments I left.
Also, we should adjust the CI to also build without the nightly feature and with the stable feature. |
Another thing: What happens when the user enables both the |
if "nightly" and "stable" are enabled, then it results in "nightly" |
which is nice, as one can start with "stable" and add "nightly" as part of other feature sets |
Makes sense! |
done |
left out windows.. don't know how to install the needed toolchain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update! Looks good to me now.
It would be nice if you could add a short section about the nightly
and stable
features to the README. We should also mention that the stable
feature is only tested on Linux and macOS.
do not merge yet.. ironing out some macos assembler issues |
ok.. lgtm.. Review again please |
default is "nightly" to compile with stable rust: x86_64 = { version = "0.9", default-features = false, features = [ "stable" ] }
Published as version 0.9.3. |
default is "nightly"
to compile with stable rust:
x86_64 = { version = "0.9", default-features = false, features = [ "stable" ] }