ShellParams: Add subshell test #922
Conversation
Useful to get the shell arguments for a commandline application. Signed-off-by: Daniel Schaefer <[email protected]>
Signed-off-by: Daniel Schaefer <[email protected]>
Signed-off-by: Daniel Schaefer <[email protected]>
It's safer. Signed-off-by: Daniel Schaefer <[email protected]>
To test whether the ShellParams protocol works properly, we should try it with different parameters, not just the default of one. To do that we need to run the test runner again. So that it doesn't run all of the tests again, we test whether the ShellParams protocol is installed and whether arguments have been passed. If it's not installed or if there are no arguments, the default tests run. As part of ShellParams test, it launches the second instance of test_runner.efi with parameters. That instance will only run a specific subshell test to check if the parameters were correctly passed. Signed-off-by: Daniel Schaefer <[email protected]>
|
Sorry, wanted to make it a draft. |
| @@ -45,6 +67,17 @@ fn efi_main(image: Handle, mut st: SystemTable<Boot>) -> Status { | |||
| // Test all the boot services. | |||
| let bt = st.boot_services(); | |||
|
|
|||
| // If ShellParametes protocol present and run with arguments, | |||
There was a problem hiding this comment.
| // If ShellParametes protocol present and run with arguments, | |
| // If ShellParameters protocol present and run with arguments, |
Could we instead just launch the test runner with more params in the first place? I.e. where we currently have |
Sure, just a single test case then? |
|
I think that would be best, yes, just to keep the test flow simpler. Unless you think there's a high chance we'd be missing bugs from not doing the extra subshell test. |
|
Ok sure, I integrated that simple test in #772 |
Separate experimental PR based on #772.
It works but I'm not sure if you agree with how it's run.
To test whether the ShellParams protocol works properly, we should try
it with different parameters, not just the default of one.
To do that we need to run the test runner again. So that it doesn't run
all of the tests again, we test whether the ShellParams protocol is
installed and whether arguments have been passed. If it's not installed
or if there are no arguments, the default tests run.
As part of ShellParams test, it launches the second instance of
test_runner.efi with parameters. That instance will only run a specific
subshell test to check if the parameters were correctly passed.