Handle panics by unwinding the stack and implement check_event method
#282
+42
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GabrielMajeri
changed the title
check_event method
nicholasbishop
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default panic mechanism was changed to
abortin 58a623a, to avoid issues with event callbacks. However, as far as I can tell, since rust-lang/rust#76570, unwinding is automatically disabled forextern "efiapi"functions, so there shouldn't be any issue with usingpanic = unwindby default.I've implemented the
check_eventmethod and added a new test for creating a custom event, and after playing around a bit, there seemed to be no issues with panics inside the notify function.