Implement the multiprocessor wakeup mechanism. #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsaacWoods
requested changes
Oct 13, 2024
acpi/src/madt.rs
Outdated
| impl Madt { | ||
| pub fn wakeup_aps( |
There was a problem hiding this comment.
It feels odd to me to implement high-level functionality like booting APs directly on the MADT. This should probably be implemented in the platform layer - this should extract the physical address of the mailbox during its existing MADT parsing, and then provide this method on PlatformInfo I feel
There was a problem hiding this comment.
I wonder if it can be a separate function in the platform layer? It doesn't seem to belong to PlatformInfo.
Hsy-Intel
force-pushed
the
mpwk
branch
3 times, most recently
from
8ac4fac
to
e023d9d
Compare
|
Hi @IsaacWoods , could you review this PR again when you have time? Thanks~ |
IsaacWoods
requested changes
Nov 8, 2024
The issue has been fixed. Thanks for your comments. @IsaacWoods |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ACPI specification r6.4 introduced the Multiprocessor Wakeup Structure to let the bootstrap processor wake up application processors with a mailbox.
This PR follows the design and definition of ACPI specification and has been verified in my project.