Merge #201

201: Use standard library for float from_str_radix with radix 10 r=cuviper a=tspiteri Fixes #198. While at it, also make parsing of the `"-NaN"` string match the standard library. Co-authored-by: Trevor Spiteri <[email protected]>
rust-num · Mar 1, 2021 · 9c8f20e · 9c8f20e
2 parents e8da6fe + e71d7a9
commit 9c8f20e
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/src/lib.rs b/src/lib.rs
@@ -224,11 +224,19 @@ macro_rules! float_trait_impl {
                 use self::FloatErrorKind::*;
                 use self::ParseFloatError as PFE;
 
+                // Special case radix 10 to use more accurate standard library implementation
+                if radix == 10 {
+                    return src.parse().map_err(|_| PFE {
+                        kind: if src.is_empty() { Empty } else { Invalid },
+                    });
+                }
+
                 // Special values
                 match src {
                     "inf"   => return Ok(core::$t::INFINITY),
                     "-inf"  => return Ok(core::$t::NEG_INFINITY),
                     "NaN"   => return Ok(core::$t::NAN),
+                    "-NaN"  => return Ok(-core::$t::NAN),
                     _       => {},
                 }