-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why hiding field of ExtendedGcd? #39
Comments
It's just meant as an approximation of the newer |
Yep, removing this field makes sense |
I hit this when trying to implement |
46: Remove hidden field from ExtendedGcd r=cuviper a=tspiteri Fixes #39 Co-authored-by: Trevor Spiteri <[email protected]>
Noticed that there's no way to construct ExtendedGcd from user code (because of hidden field), and I can't implement
Integer::extended_gcd
(as I can't construct being returned structure) and I have to use your generic implementation of egcd. Perhaps there should beExtendedGcd::new()
constructor?The text was updated successfully, but these errors were encountered: