macvlan: add IFLA_MACVLAN_BC_ options #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luap99
added a commit
to Luap99/netavark
that referenced
this pull request
May 24, 2023
Expose the netlink IFLA_MACVLAN_BC_CUTOFF option as bclim like the ip command does. We still need c/common and podman patches to allow this option for podman network create. Also I created a PR[1] upstream in the netlink lib to allow setting these options directly instead of using the DefaultNla work around as I do here. [1] rust-netlink/netlink-packet-route#32 This is needed for https://bugzilla.redhat.com/show_bug.cgi?id=2183896 Signed-off-by: Paul Holzinger <[email protected]>
Luap99
added a commit
to Luap99/netavark
that referenced
this pull request
May 24, 2023
Expose the netlink IFLA_MACVLAN_BC_CUTOFF option as bclim like the ip command does. We still need c/common and podman patches to allow this option for podman network create. Also I created a PR[1] upstream in the netlink lib to allow setting these options directly instead of using the DefaultNla work around as I do here. [1] rust-netlink/netlink-packet-route#32 This is needed for https://bugzilla.redhat.com/show_bug.cgi?id=2183896 Signed-off-by: Paul Holzinger <[email protected]>
Luap99
added a commit
to Luap99/netavark
that referenced
this pull request
May 24, 2023
Expose the netlink IFLA_MACVLAN_BC_CUTOFF option as bclim like the ip command does. We still need c/common and podman patches to allow this option for podman network create. Also I created a PR[1] upstream in the netlink lib to allow setting these options directly instead of using the DefaultNla work around as I do here. TODO: add test but for now this option is not in a released version of iproute so there is no way to check for it right now. [1] rust-netlink/netlink-packet-route#32 This is needed for https://bugzilla.redhat.com/show_bug.cgi?id=2183896 Signed-off-by: Paul Holzinger <[email protected]>
Luap99
added a commit
to Luap99/netavark
that referenced
this pull request
May 24, 2023
Expose the netlink IFLA_MACVLAN_BC_CUTOFF option as bclim like the ip command does. We still need c/common and podman patches to allow this option for podman network create. Also I created a PR[1] upstream in the netlink lib to allow setting these options directly instead of using the DefaultNla work around as I do here. TODO: Add a test but for now this option is not in a released version of iproute so there is no way to check for it right now. [1] rust-netlink/netlink-packet-route#32 This is needed for https://bugzilla.redhat.com/show_bug.cgi?id=2183896 Signed-off-by: Paul Holzinger <[email protected]>
Luap99
added a commit
to Luap99/netavark
that referenced
this pull request
May 24, 2023
Expose the netlink IFLA_MACVLAN_BC_CUTOFF option as bclim like the ip command does. We still need c/common and podman patches to allow this option for podman network create. Also I created a PR[1] upstream in the netlink lib to allow setting these options directly instead of using the DefaultNla work around as I do here. TODO: Add a test but for now this option is not in a released version of iproute so there is no way to check for it right now. [1] rust-netlink/netlink-packet-route#32 This is needed for https://bugzilla.redhat.com/show_bug.cgi?id=2183896 Signed-off-by: Paul Holzinger <[email protected]>
Luap99
added a commit
to Luap99/netavark
that referenced
this pull request
May 24, 2023
Expose the netlink IFLA_MACVLAN_BC_CUTOFF option as bclim like the ip command does. We still need c/common and podman patches to allow this option for podman network create. Also I created a PR[1] upstream in the netlink lib to allow setting these options directly instead of using the DefaultNla work around as I do here. TODO: Add a test but for now this option is not in a released version of iproute so there is no way to check for it right now. [1] rust-netlink/netlink-packet-route#32 This is needed for https://bugzilla.redhat.com/show_bug.cgi?id=2183896 Signed-off-by: Paul Holzinger <[email protected]>
Luap99
added a commit
to Luap99/netavark
that referenced
this pull request
May 24, 2023
Expose the netlink IFLA_MACVLAN_BC_CUTOFF option as bclim like the ip command does. We still need c/common and podman patches to allow this option for podman network create. Also I created a PR[1] upstream in the netlink lib to allow setting these options directly instead of using the DefaultNla work around as I do here. TODO: Add a test but for now this option is not in a released version of iproute so there is no way to check for it right now. [1] rust-netlink/netlink-packet-route#32 This is needed for https://bugzilla.redhat.com/show_bug.cgi?id=2183896 Signed-off-by: Paul Holzinger <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #32 +/- ##
==========================================
+ Coverage 45.14% 45.22% +0.07%
==========================================
Files 75 74 -1
Lines 6215 6050 -165
==========================================
- Hits 2806 2736 -70
+ Misses 3409 3314 -95
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Luap99
added a commit
to Luap99/netavark
that referenced
this pull request
May 25, 2023
Expose the netlink IFLA_MACVLAN_BC_CUTOFF option as bclim like the ip command does. We still need c/common and podman patches to allow this option for podman network create. Also I created a PR[1] upstream in the netlink lib to allow setting these options directly instead of using the DefaultNla work around as I do here. TODO: Add a test but for now this option is not in a released version of iproute so there is no way to check for it right now. [1] rust-netlink/netlink-packet-route#32 This is needed for https://bugzilla.redhat.com/show_bug.cgi?id=2183896 Signed-off-by: Paul Holzinger <[email protected]>
Luap99
added a commit
to Luap99/netavark
that referenced
this pull request
May 25, 2023
Expose the netlink IFLA_MACVLAN_BC_CUTOFF option as bclim like the ip command does. We still need c/common and podman patches to allow this option for podman network create. Also I created a PR[1] upstream in the netlink lib to allow setting these options directly instead of using the DefaultNla work around as I do here. TODO: Add a test but for now this option is not in a released version of iproute so there is no way to check for it right now. [1] rust-netlink/netlink-packet-route#32 This is needed for https://bugzilla.redhat.com/show_bug.cgi?id=2183896 Signed-off-by: Paul Holzinger <[email protected]>
cathay4t
requested changes
Jun 25, 2023
Add new IFLA_MACVLAN_BC_QUEUE_LEN, IFLA_MACVLAN_BC_QUEUE_LEN_USED and IFLA_MACVLAN_BC_CUTOFF kernel options for macvlan and macvtap. https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=d4bff72c8401 https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=954d1fa1ac93 Signed-off-by: Paul Holzinger <[email protected]>
|
Test added |
cathay4t
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new IFLA_MACVLAN_BC_QUEUE_LEN, IFLA_MACVLAN_BC_QUEUE_LEN_USED and IFLA_MACVLAN_BC_CUTOFF kernel options for macvlan and macvtap.
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=d4bff72c8401 https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=954d1fa1ac93