Add support for more index types in s![] macro #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jturner314
force-pushed
the
more-slice-types
branch
2 times, most recently
from
240515e to
14ff223
Compare
This commit also removes use of the `Ixs` type alias in the `slice` module.
jturner314
force-pushed
the
more-slice-types
branch
from
ff7498a to
3acf464
Compare
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for more index types in the
s![]macro. (This was discussed briefly in #369.)The only thing I don't like about this PR is that it uses
asto convert thestepargument (of arbitrary type) toisizein thes![]macro. It would be possible to add a conversion trait to handle this, but theasapproach is much simpler.