Use gradle when the build target is Aab
#156
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
force-pushed
the
gradle-library-dependencies
branch
from
bd2052f to
8c72628
Compare
Instead of explicitly requiring `gradle: true` in the manifest, enable it by default when the (implicit or explicit!) output package format is `Aab` for convenience, as there is currently no way to select the `gradle` backend via command line parameters and hardcoding it in `manifest.yaml` makes it inconvenient to build `Apk`s with the "native" builtin backend. Also insert validation in case the user explicitly inserts `gradle: false` but tries to build `Aab`s. The default for releases is still `Aab` if there is an explicit `gradle: true`, but an `Apk` is built otherwise.
MarijnS95
force-pushed
the
gradle-if-aab
branch
from
9a07c4a to
f7c690c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #140 to prevent conflicts
Instead of explicitly requiring
gradle: truein the manifest, enable it by default when the (implicit or explicit!) output package format isAabfor convenience, as there is currently no way to select thegradlebackend via command line parameters and hardcoding it inmanifest.yamlmakes it inconvenient to buildApks with the "native" builtin backend.Also insert validation in case the user explicitly inserts
gradle: falsebut tries to buildAabs. The default for releases is stillAabif there is an explicitgradle: true, but anApkis built otherwise.