Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo apk -- build --release doesn't build in release profile anymore #375

Closed
torokati44 opened this issue Dec 7, 2022 · 3 comments · Fixed by rust-mobile/cargo-apk#4
Closed

Comments

@torokati44
Copy link

I'm trying to use cargo-apk to only build a shared library from Rust which then I'll load and use from a "regular" (Java+Kotlin) Android project - so I don't need any APK generation, code signing, etc. from cargo-apk.

I was using cargo apk -- build --release for this, as suggested here: #326 (comment)

This used to work well, however, since then, it has stopped building in release mode for some reason, as can be seen here:
https://github.com/torokati44/ruffle-android/actions/runs/3623790481/jobs/6110051919

image

image

@torokati44
Copy link
Author

Perhaps this was caused by #363.

@MarijnS95
Copy link
Member

This is specifically caused by e2b9db4 as args.update_from_arg_matches(&m).unwrap(); is setting Args::release back to false if --release wasn't present in the new args.

I'll investigate if this is intended, if there's a way around it, or if I should just revert that specific commit.

@torokati44
Copy link
Author

Thank you for the quick fix, now it works just as well as before!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment