Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release cargo-apk-0.9.7 #376

Closed
wants to merge 3 commits into from
Closed

Release cargo-apk-0.9.7 #376

wants to merge 3 commits into from

Conversation

MarijnS95
Copy link
Member

Fixes #375

This reverts commit e2b9db4, merged as
part of 419df14 ("cargo-apk: Reimplement "default" (`--`) subcommand
trailing args for `cargo` (#363)").
This provides better workspace detection based on `$PWD` or
`--manifest-path`.
Copy link
Contributor

@dvc94ch dvc94ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong repo

@MarijnS95
Copy link
Member Author

Like I said I don't have much time for all this shuffling around. It's okay with me as long as it's not disruptive at this moment.

@dvc94ch
Copy link
Contributor

dvc94ch commented Dec 9, 2022

you're saying it's too inconvenient to open a PR in the correct repo?

@MarijnS95
Copy link
Member Author

It would be a bit inconvenient to transplant the commits to the other repo (but that has to happen regardless).

@rib mentioned in emails to owners for these crates that I won't be allowed to make releases, but I can since I am part of @rust-windowing/publishers, and cargo doesn't care which git repositories a crate is hosted at for that to work. Regardless, it'd be great if I could have direct control over the crates (and in turn grant publishing rights to a new group over at @rust-mobile).

@dvc94ch
Copy link
Contributor

dvc94ch commented Dec 11, 2022

Mmh you won't be allowed to make releases? I'm missing some context here. Are you and @rib still not getting along?

@MarijnS95
Copy link
Member Author

I would, unless I missed some context when @rib emailed the current owners of these crates (on crates.io) where he mentioned that. Which I thank him for sending that by the way, saves me some time and effort!

@rib
Copy link
Contributor

rib commented Dec 11, 2022

@rib mentioned in emails to owners for these crates that I won't be allowed to make releases, but I can since I am part of @rust-windowing/publishers

aah, right, good point, for some reason I was thinking that once the repo is split then you'd end up loosing permission to publish because I was thinking that you were reliant on credentials that were associated with the android-ndk-rs repo.

If you're also a member of @rust-windowing/publishers then there's hopefully nothing to worry about in the short term, and we can follow up on any ownership changes for crates asynchronously

@rib
Copy link
Contributor

rib commented Dec 11, 2022

Mmh you won't be allowed to make releases? I'm missing some context here. Are you and @rib still not getting along?

:) no worries here; @MarijnS95 isn't saying that I was asserting that they would be disallowed. I sent some emails to tomaka and Osspial asking them to give @MarijnS95 co-ownership of the cargo-apk and ndk-build crates on crates.io because I was worried that @MarijnS95 wouldn't be able to make releases from the standalone repo.

@rib
Copy link
Contributor

rib commented Dec 11, 2022

It would be a bit inconvenient to transplant the commits to the other repo (but that has to happen regardless).

btw @MarijnS95 I was thinking we may be able to directly transfer any pending PRs/Issues for cargo-apk directly from this repo - though that requires that you have write permission to this repo to do that: https://docs.github.com/en/issues/tracking-your-work-with-issues/transferring-an-issue-to-another-repository

It would be rather awkward to land anything here because it means I have to re-run the filtering etc for the standalone repo.

If someone gives me write access to this repo I could look at transferring cargo-apk issues/PRs (probably best to wait until we merge PR #374 ideally)

Alternatively for smalls PRs like this then I can cherry pick the patches and create an equivalent PR

@rib
Copy link
Contributor

rib commented Dec 11, 2022

I've created an equivalent PR against the standalone repo here: rust-mobile/cargo-apk#1

@MarijnS95
Copy link
Member Author

Disclaimer: What I ended up replying here should probably all have gone into #372...


aah, right, good point, for some reason I was thinking that once the repo is split then you'd end up loosing permission to publish because I was thinking that you were reliant on credentials that were associated with the android-ndk-rs repo.

If you're also a member of @rust-windowing/publishers then there's hopefully nothing to worry about in the short term, and we can follow up on any ownership changes for crates asynchronously

Yes I think it's fine for now, but we have to make sure that @rust-windowing/publishers doesn't kick me out after effectively all repos I need publish rights for have moved out. Until I receive the appropriate rights of course.

I will also see about updating the GitHub secret to use a new token from my account, instead of publishing every release (performed by me for the past year-or-so) via Francesca's account 😬

btw @MarijnS95 I was thinking we may be able to directly transfer any pending PRs/Issues for cargo-apk directly from this repo - though that requires that you have write permission to this repo to do that: https://docs.github.com/en/issues/tracking-your-work-with-issues/transferring-an-issue-to-another-repository

I definitely wanted to transfer relevant issues to the other repo before opening PRs against it. That doesn't seem possible for PRs though, since they're heavily dependent on the available git history (I don't even think you can do it between direct forks).

However, it seems I'm only allowed to transfer to other repos under the @rust-windowing organization:

image

It would be rather awkward to land anything here because it means I have to re-run the filtering etc for the standalone repo.

That is true, and mentioned above by me; I just wasn't sure how far along your filtering was in terms of demonstrating "this is how it will end up looking like" versus "everything is moved now, please use the new system". Looks like the latter, I'll try and review your PRs soon to make sure the CI publishing keeps working when we land (the "transferred" version of) this PR.

If someone gives me write access to this repo I could look at transferring cargo-apk issues/PRs (probably best to wait until we merge PR #374 ideally)

I don't have enough rights for that, unfortunately. @rust-windowing/publishers, any help here? Can you also give me enough rights to access the settings menu and initiate the transfer to @rust-mobile? @madsmtm?

Alternatively for smalls PRs like this then I can cherry pick the patches and create an equivalent PR

It's weekend now, I can easily take care of transplanting my own PRs on Monday...

I've created an equivalent PR against the standalone repo here: rust-mobile/cargo-apk#1

But you already took care of that 😶

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo apk -- build --release doesn't build in release profile anymore
3 participants