-
-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add website to infrastructure #87
Conversation
* use section infrastructure for automatic highlighting * the trait constraint in `src/metrics_regression.rs` is relaxed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides just wondering if we want to host directly from the rust-ml group, everything else looks good! I've clicked around the current site, and didn't run into any bugs. If you're satisfied, this looks good to go from me :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work on the website💪🏻 I believe that cleaning up the main folder by moving all the algorithms to their subfolder was a very good idea too and it looks much nicer now.
I only have two suggestions:
- Should we add the link to the website in the readme for linfa?
- In the
About
page of the website (in the mobile version) the table obviously does not fit, I was wondering if maybe it would be better to make only the table side-scrollable and not the whole page? This is a very picky comment so feel free to ignore it 😅
yes and yes, will figure something out for the table later this day :) |
I would publish the website at |
* link website in README * make table horizontally scrollable in mobile version * update elasticnet example * update `base_url` link in configuration
okay let's merge and see what happens |
damn the links in README are not updated 😅 I will push another commit when the website is online |
fixed in latest commit and everything seems fine 👍 |
Everything seems to be working fine 🚀 |
Links to algorithms in About page are broken. |
yep fixed in f79fe9e |
Nice website! Bravo! 👏 👏 👏 |
This PR adds an entry website, where we can pitch the idea about linfa and have some announcements/news section.
docs/website
: renderedalgorithms/
because the root became too messygh-pages
sorry for the large number of file changes, you can search for diffs in a subpath with
git diff master docs/website/
😅