CI: Fix Marker Book Deployment #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xFrednet
added
C-bug
Veetaha
reviewed
Aug 21, 2023
| @@ -36,7 +36,7 @@ jobs: | |||
| mkdir deploy | |||
| cp ./docs/index.html ./deploy/index.html | |||
| - name: Build the book | |||
| run: mdbook build docs/book --dest-dir deploy/book | |||
| run: mdbook build docs/book --dest-dir ../../deploy/book | |||
There was a problem hiding this comment.
That's strange. The step above puts the index.html into ./deploy. Then why is this ../../deploy?
There was a problem hiding this comment.
Ah, I see this is in the help:
-d, --dest-dir <dest-dir> Output directory for the book
Relative paths are interpreted relative to the book's root directory.
If omitted, mdBook uses build.build-dir from book.toml or defaults to `./book`.
There was a problem hiding this comment.
The path after mdbook build changes the directory that mdbook build is executed. The --det-dir as to be relative to the book source directory. It's a weird thing, but somehow works (hopefully)
There was a problem hiding this comment.
I ran this locally and it put everything under ./deploy/book afterwards. The book sub dir is to have it as a sub url
|
Now everything works 🎉 Thank you updating the CI @Veetaha ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix book deployment after switching to merge queues in #222