Skip to content

Commit

Permalink
CI: Only test our action on libraries that can build on stable
Browse files Browse the repository at this point in the history
  • Loading branch information
xFrednet committed Dec 30, 2023
1 parent 285fea1 commit dd2aab9
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 13 deletions.
18 changes: 17 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -234,4 +234,20 @@ jobs:
# There may be bugs in the release build of our binaries. For example, in the past
# we saw that LTO could lead to exit code: 0xc0000005, STATUS_ACCESS_VIOLATION crash

- run: cargo marker -l 'marker_lints="*"'
# FIXME: The stable version of Marker tested by this command might use a different toolchain
# version then the one used for the development of rustc driver. Running Marker only loads the
# library files for the toolchain it's executed with and "ignores" the toolchain defined in
# `rust-toolchain.toml`. Therefore, it's not possible to run the stable version of marker
# on `marker_rustc_driver`.
# In the future it would be better to run this smoke test on bigger libraries like tokio, serde
# bevy etc. For that, it would be good to extract the lintcheck tool from Clippy into a standalone
# tool.
- run: >-
cargo +stable marker
-l 'marker_lints="*"'
--
--workspace
--exclude marker_rustc_driver
--exclude marker_lints
--exclude marker_uitest
4 changes: 2 additions & 2 deletions scripts/release/install.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,9 @@ Using config env vars (override these if needed):
$version = "0.5.0"
# endregion replace marker version unstable

# region replace rust toolchain release
# region replace rust toolchain unstable
$toolchain = "nightly-2023-11-16"
# endregion replace rust toolchain release
# endregion replace rust toolchain unstable

# Log the command, execute, and fail if its exit code is non-zero.
# Surprisingly PowerShell can't do the exit code checks for us out of the box.
Expand Down
4 changes: 2 additions & 2 deletions scripts/release/install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ echo "Bash version: $BASH_VERSION" >&2
version=0.5.0
# endregion replace marker version unstable

# region replace rust toolchain release
# region replace rust toolchain unstable
toolchain=nightly-2023-11-16
# endregion replace rust toolchain release
# endregion replace rust toolchain unstable

function step {
local cmd="$1"
Expand Down
8 changes: 0 additions & 8 deletions scripts/release/set-version.diff
Original file line number Diff line number Diff line change
Expand Up @@ -211,17 +211,9 @@
-$version = "X.Y.Z"
+$version = "0.1.0"
# endregion replace marker version unstable
# region replace rust toolchain release
-$toolchain = "nightly-YYYY-MM-DD"
+$toolchain = "nightly-2023-01-01"
# endregion replace rust toolchain release

=== scripts/release/install.sh ===
# region replace marker version unstable
-version=X.Y.Z
+version=0.1.0
# endregion replace marker version unstable
# region replace rust toolchain release
-toolchain=nightly-YYYY-MM-DD
+toolchain=nightly-2023-01-01
# endregion replace rust toolchain release

0 comments on commit dd2aab9

Please sign in to comment.