Only create a relnotes tracking issue for finished FCPs if they have disposition merge #1904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmease
commented
Feb 16, 2025
| @@ -27,6 +27,8 @@ struct RelnotesState { | |||
| relnotes_issue: Option<u64>, | |||
| } | |||
|
|
|||
| const TITLE_PREFIX: &str = "Tracking issue for release notes"; | |||
There was a problem hiding this comment.
Drive-by refactoring to ensure that the two usage sites don't get out of sync.
src/handlers/relnotes.rs
Outdated
| && e.issue | ||
| .labels | ||
| .iter() | ||
| .any(|label| label.name == "disposition-merge") | ||
| { |
There was a problem hiding this comment.
In practice this shoudn't be prone to race conditions because disposition-* gets applied during proposed-final-comment-period already.
src/handlers/relnotes.rs
Outdated
| && e.issue | ||
| .labels | ||
| .iter() | ||
| .any(|label| label.name == "disposition-merge") |
There was a problem hiding this comment.
Could you add parentheses or perhaps extract let is_fcp_merge = ...?
…disposition merge
fmease
force-pushed
the
relnotes-tracking-must-be-disposition-merge
branch
from
5642640 to
e72f53c
Compare
Mark-Simulacrum
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses rust-lang/rust#137075 (comment)
r? @Mark-Simulacrum || (release ∩ infra)