Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistencies that slipped through the cracks #267

Closed
wants to merge 7 commits into from
Closed

Fix inconsistencies that slipped through the cracks #267

wants to merge 7 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 19, 2020

I don't intend to spam this repository with shallow pull requests, but it looks like a few minor inconsistencies with the working groups were either introduced since I opened #127 or were simply overlooked. I believe I've fixed them now.

@ghost
Copy link
Author

ghost commented Feb 19, 2020

Some of my changes here are subjective; I thought that they made it seem more consistent/professional when looking at the site. If it's preferred that I revert them, let me know.

@Manishearth
Copy link
Member

I don't think the working group names should be lower cased. The "Working Group" perhaps should be uppercased

@Mark-Simulacrum
Copy link
Member

r? @Manishearth in that case, I personally don't really care either way.

@ghost
Copy link
Author

ghost commented Feb 19, 2020

I don't think the working group names should be lower cased. The "Working Group" perhaps should be uppercased

Should the whole title be like that, then?

@Manishearth
Copy link
Member

Should the whole title be like that, then?

Yes

@nikomatsakis
Copy link
Contributor

These do look like good changes -- I don't have a strong opinion about the capitalization of Working Group vs working group.

@ghost ghost closed this Dec 26, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants