Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove const_str_as_bytes feature gate #819

Merged
merged 1 commit into from
Oct 10, 2019
Merged

Remove const_str_as_bytes feature gate #819

merged 1 commit into from
Oct 10, 2019

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Oct 6, 2019

const_str_as_bytes has been stabilized in rust-lang/rust#63770.

@rust-highfive
Copy link

r? @gnzlbg

(rust_highfive has picked a reviewer for you, use r? to override)

lu-zero
lu-zero approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@lu-zero lu-zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to sync up the CI compilers though.

@lu-zero
Copy link
Contributor

lu-zero commented Oct 7, 2019

x86_64-unknown-linux-gnu-emulated seems to have problems unrelated to this patch.

@gnzlbg gnzlbg merged commit 1d1ab19 into rust-lang:master Oct 10, 2019
@taiki-e taiki-e deleted the const_str_as_bytes branch October 10, 2019 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lu-zero lu-zero lu-zero approved these changes

Assignees

@gnzlbg gnzlbg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@taiki-e @rust-highfive @lu-zero @gnzlbg