-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove std::simd #528
remove std::simd #528
Conversation
I've run out of CI capacity so I am posting this here a bit early, its still WIP but most things build already and most tests on most targets pass. I won't merge this till the |
Keeping FromBits and IntoBits would be less painful for our theoretical users (and for us when writing the tests) :) |
Since we are removing all portable vector types from here, it is going to be painful anyways. For us.. we can just use If someone wants to send a PR adding them for the types in the new An alternative is to just abbreviate transmute to For this to land, the ppv crate will need to implement the |
This has the downside that you can't experiment with portable SIMD on Godbolt anymore, which was very useful. I guess someone should just add the ability to use crates to Godbolt though instead. |
@CryZe yeah that was very useful, godbolt supports using libraries for other languages (e.g. C++) so maybe we should open an issue there. Now that godbolt has gained cross-compilation support, this would be very very useful. |
…or some intrinsics. These are new optimizations
@gnzlbg would you be ok merging this for now to get CI green again, but we'll hold off on updating the submodule in rust-lang/rust until you've published? |
Done, I might get time to get the From/IntoBits impl ported tomorrow. The submodule update will still take a while but maybe we could start doing that at the end of this week, since that should fix all of the linker errors that people were seeing due to missing definitions of some of the vector functions. |
`std::simd` (feature-gated with `stdsimd`) was removed by this pull request: <rust-lang/stdarch#528>.
Closes #525 .