use merge queue #1683
use merge queue #1683
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) some time within the next two weeks. |
| git add . | ||
| git -c user.name='ci' -c user.email='ci' commit -m init | ||
| git push -f -q https://git:${{ secrets.github_token }}@github.com/${{ github.repository }} HEAD:gh-pages | ||
| if: github.event_name == 'push' && github.event.ref == 'refs/heads/master' |
There was a problem hiding this comment.
I removed the if, and moved the Publish step to the doc.yml.
I kept the rest of the job here so that we know in advance if the job fail 👍
There was a problem hiding this comment.
btw, was the if every triggered? I'm asking since the on condition looks like this:
push:
branches:
- auto
- try
There was a problem hiding this comment.
Actually I think can just drop the docs publishing. They've been included in the standard library for ages.
There was a problem hiding this comment.
feel free to push the change 👍
There was a problem hiding this comment.
Actually I just removed the file 👍
I guess you still need to check if the docs are correct, so I kept the previous steps 👍
| pull_request: | ||
| branches: | ||
| - master |
There was a problem hiding this comment.
oh, I removed this filter, feel free to re-add it
|
actually I forgot the conclusion job! Adding it now |
| # Print the dependent jobs to see them in the CI log | ||
| jq -C <<< '${{ toJson(needs) }}' | ||
| # Check if all jobs that we depend on (in the needs array) were successful. | ||
| jq --exit-status 'all(.result == "success")' <<< '${{ toJson(needs) }}' |
There was a problem hiding this comment.
copy pasted the same check we added in other repos
https://github.com/rust-lang/rust-clippy/blob/8bc1a9e49a22b0e43c942102b13ded8704851228/.github/workflows/clippy_pr.yml#L62
|
Can you approve rust-lang/team#1615 ? Even if you don't have write access is fine. It's just to have another pair of eyes 👍 |
No description provided.