-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x86 Various issues with extract_epiNN functions #867
Comments
The second one is definitely a bug which should be fixed. For the first one, apparently our intrinsics data has the return type as int8/int16:
|
Looks like https://github.com/rust-lang/stdarch/blob/master/crates/stdarch-verify/x86-intel.xml is out of date. That one's from 09/07/2017 but the most recent one is from 06/05/2020. |
jethrogb
pushed a commit
to jethrogb/stdsimd
that referenced
this issue
Jun 9, 2020
* Update Intel intrisics definitions with the latest version * Update _mm256_extract_epi{8,16} to match latest definition * Fix _mm_extract_epi16 sign extension Fixes rust-lang#867
jethrogb
pushed a commit
to jethrogb/stdsimd
that referenced
this issue
Jun 9, 2020
* Update Intel intrinsics definitions with the latest version * Update _mm256_extract_epi{8,16} to match latest definition * Fix _mm_extract_epi16 sign extension Fixes rust-lang#867
Amanieu
pushed a commit
that referenced
this issue
Jun 9, 2020
* Update Intel intrinsics definitions with the latest version * Update _mm256_extract_epi{8,16} to match latest definition * Fix _mm_extract_epi16 sign extension Fixes #867
Please re-open the issue (due to #878) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1. Inconsistent function signatures
The SSE versions have the following signatures:
But the AVX versions have the following:
Note the difference in return type. Since Intel specifies these all return
int
, it's not clear how this happened. I thought the function signatures are supposed to be machine-checked?2. Incorrect sign extension
This prints:
ffffffff
. Intel specifies the upper 16 bits should be 0.cc @AdrianCX
The text was updated successfully, but these errors were encountered: