Add support for 'all' feature on QNX Neutrino for v0.4.x #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thomasdezeeuw
approved these changes
Mar 25, 2023
There was a problem hiding this comment.
I saw as part of #381 it was mentioned that the v0.4.x branch is not taking PRs, so apologies if this is not appropriate. When those changes were backported these
target_osflags were not applied (I presume as the function signatures are totally different in master) which prevents compilation on 0.4 branches.
Only backports are accept to make sure we don't miss any commits in newer versions, but this is a v0.4 specific fix, so it's fine.
|
Thanks @Tom-Goring |
|
Thanks very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I saw as part of #381 it was mentioned that the v0.4.x branch is not taking PRs, so apologies if this is not appropriate. When those changes were backported these
target_osflags were not applied (I presume as the function signatures are totally different in master) which prevents compilation on 0.4 branches.Not sure what the best way to resolve is - recommendations welcome 😄
CC: @flba-eb @gh-tr