-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.5 #394
Release v0.5 #394
Conversation
Btw, you might want to add semver checking to CI like we recently did for Tokio. |
You mean https://github.com/tokio-rs/tokio/blob/ca9f7ee9f4750d6bb8a073ab4df1b7e4555857ad/.github/workflows/ci.yml#L233-L248 and https://github.com/obi1kenobi/cargo-semver-checks? |
Yes. |
Created #396 for it. |
Thanks for the reviews @Darksonn |
FWIW, this semver bump is causing a ripple effect bytecodealliance/cap-std@963eebf#r121651362 Not saying it was wrong to do...but I just want to ensure the cost/benefit is more visible. |
I'm aware of the cost. v0.5 was required mainly to resolve #218, which showed that some of the API in v0.4 is unsound (it can use an arbitrary integer as fd without Updating a heavily used crate in a breaking way is a pain, I'm aware, but at times it's required. v0.5 was the second breaking change in roughly the same amount of years. I try to keep a detailed changelog: https://github.com/rust-lang/socket2/blob/master/CHANGELOG.md#050 with clearly indicated API breakage and upgrade path. In other words I try to make the update experience as painless as possible. All that said, updating existing, working code for little (perceived) benefit is always an annoying experience, just know that I'm not doing it annoy people. |
/cc @abonander