Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update git2 to compile with latest rustc nightly #63

Closed
wants to merge 1 commit into from
Closed

Update git2 to compile with latest rustc nightly #63

wants to merge 1 commit into from

Conversation

fpoli
Copy link

@fpoli fpoli commented Jun 1, 2021

This should work around the issue rust-lang/rust#85574 by including rust-lang/git2-rs#712.

(I haven't tested this change locally.)

@pietroalbini
Copy link
Member

Thanks for opening the PR!

0.13.12 is semver-compatible with 0.13.20, so you should be able to cargo update -p git2 on your project to get the latest version. Does that work for you?

@fpoli
Copy link
Author

fpoli commented Jun 3, 2021

Thanks for opening the PR!

0.13.12 is semver-compatible with 0.13.20, so you should be able to cargo update -p git2 on your project to get the latest version. Does that work for you?

Good point, thanks! Updating git2 on our project is enough to work around the issue.

@pietroalbini
Copy link
Member

Great! Closing the PR then.

@fpoli fpoli deleted the patch-1 branch June 4, 2021 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants