Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use more workspace-wide configurations #4061

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

rami3l
Copy link
Member

@rami3l rami3l commented Oct 24, 2024

This PR does the following cleanup WRT Cargo.toml:

  • Updated Cargo.toml to use workspace settings for version, edition, and license fields (cherry-picked from dist: bump rustup version to 1.28.0 #4041) [1] [2]
  • Added workspace linting configurations for Rust idioms and clippy lints. (Cargo.toml, download/Cargo.toml) [1] [2]

This also prepares the repo for its upcoming migration to Rust 2024 by making it easier to enable rust-2024-compatibility across the project. With this change, that will look like:

[workspace.lints.rust]
rust_2018_idioms = { level = "deny", priority = -1 }
rust-2024-compatibility = { level = "warn", priority = -2 }

@rami3l rami3l requested review from djc and ChrisDenton October 24, 2024 13:11
Copy link
Member

@ChrisDenton ChrisDenton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workspace inheritance is more verbose than I'd like but only setting information in one place is definitely an advantage.

@rami3l rami3l added this pull request to the merge queue Oct 25, 2024
Merged via the queue into rust-lang:master with commit 4678cbe Oct 25, 2024
27 checks passed
@rami3l rami3l deleted the chore/workspace-lints branch October 25, 2024 01:28
src/diskio/threaded.rs Show resolved Hide resolved
src/test/mock/clitools.rs Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants