Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring around use of Process #3860

Merged
merged 17 commits into from
Jun 5, 2024
Merged

Refactoring around use of Process #3860

merged 17 commits into from
Jun 5, 2024

Conversation

djc
Copy link
Contributor

@djc djc commented Jun 5, 2024

Various changes which I've made several times now that try to untangle the codebase mostly by inlining short and/or single-use methods. Preparation for moving more stuff out of the ambient Process global.

@djc djc requested a review from rami3l June 5, 2024 05:23
@djc djc force-pushed the cfg-current-dir branch from fec5307 to 1963396 Compare June 5, 2024 05:33
@djc djc force-pushed the cfg-current-dir branch from 1963396 to b8fa753 Compare June 5, 2024 08:42
@djc djc changed the title Get rid of Process::current_dir() Refactoring around use of Process Jun 5, 2024
src/cli/proxy_mode.rs Outdated Show resolved Hide resolved
@djc djc force-pushed the cfg-current-dir branch from ae64d51 to 0163f2e Compare June 5, 2024 09:27
Copy link
Member

@rami3l rami3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@djc djc added this pull request to the merge queue Jun 5, 2024
Merged via the queue into master with commit ee1fa08 Jun 5, 2024
26 checks passed
@djc djc deleted the cfg-current-dir branch June 5, 2024 10:53
@rami3l rami3l added this to the 1.28.0 milestone Jun 9, 2024
@rami3l rami3l mentioned this pull request Oct 6, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants