Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows Arm64 to Other Installation Methods #3854

Conversation

Alovchin91
Copy link
Contributor

@Alovchin91 Alovchin91 commented Jun 3, 2024

Split-off from #3840:

  • Adds aarch64-pc-windows-msvc download link to cloud-invalidation.txt so that this script could pick it up.
    • Does the same for aarch64-apple-darwin because why not?
  • Updates the Other Installation Methods page to include Windows Arm64 version of Rustup.
  • Enables running the aarch64-pc-windows-msvc build on PR.

Copy link
Member

@rami3l rami3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rami3l
Copy link
Member

rami3l commented Jun 3, 2024

@Alovchin91 Hmmm our CI has been red from time to time since late last week, so this might not be a very convenient time to merge your PR. Since I've just fixed a CI error on Windows (#3849), this has probably broken your changes.

Would you mind rebasing this PR? I plan to merge it immediately after #3855. Thanks a lot in advance for your comprehension 🙇 Never mind, I did this myself.

@rami3l rami3l added this to the 1.28.0 milestone Jun 3, 2024
@rami3l rami3l added O-windows Windows related A-aarch64 ARM 64bit labels Jun 3, 2024
@rami3l rami3l force-pushed the alovchin91/win-arm64-other-installation-methods branch from 484fbf2 to f2b5d77 Compare June 5, 2024 01:42
@rami3l rami3l enabled auto-merge June 5, 2024 01:43
@rami3l rami3l disabled auto-merge June 5, 2024 01:45
@rami3l rami3l enabled auto-merge June 5, 2024 01:46
@rami3l rami3l disabled auto-merge June 5, 2024 01:46
@rami3l rami3l force-pushed the alovchin91/win-arm64-other-installation-methods branch from f2b5d77 to 4f696b8 Compare June 5, 2024 01:48
@rami3l rami3l enabled auto-merge June 5, 2024 01:49
@rami3l rami3l added this pull request to the merge queue Jun 5, 2024
Merged via the queue into rust-lang:master with commit 673209a Jun 5, 2024
26 checks passed
@rami3l rami3l mentioned this pull request Oct 6, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-aarch64 ARM 64bit O-windows Windows related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants