In process test #2367
Merged
In process test #2367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In its current state, this PR blows my |
|
success! |
rbtcollins
force-pushed
the
in-process-test
branch
from
8cbd07c to
08356b1
Compare
kinnison
suggested changes
Jun 13, 2020
Comment on lines
+58
to
+67
| let matches = match cli().get_matches_from_safe(process().args_os()) { | ||
| Ok(matches) => Ok(matches), | ||
| Err(e) | ||
| if e.kind == clap::ErrorKind::HelpDisplayed | ||
| || e.kind == clap::ErrorKind::VersionDisplayed => | ||
| { | ||
| return Ok(utils::ExitCode(0)) | ||
| } | ||
| Err(e) => Err(e), | ||
| }?; |
There was a problem hiding this comment.
It might be nice to have this factored into a function given it's also used in setup_mode.rs and someone fixing something in one might miss the other.
rbtcollins
force-pushed
the
in-process-test
branch
2 times, most recently
from
3083faf to
8ec378b
Compare
The home crate also accesses global process state, so we need to abstract over it as well.
There's a certain amount of hackiness in making this work, because a number of our tests are intrinsically hostile to in-process testing, but generally speaking it works well.
The better to test with.
In-process tests have a tty and clap doesn't honour our process() abstraction; fortunately it does consult TERM, which is good enough.
rbtcollins
force-pushed
the
in-process-test
branch
from
8ec378b to
5d1bcbd
Compare
kinnison
approved these changes
Jun 13, 2020
I think its marginal - there's really only one possible spelling here, and it's dictated by clap; and we have full test coverage. I'm happy to swing back and add it in when I get some more time. |
This was referenced Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run rustup tests in-process
Using the in-process test support feature, we can now change the test runner to run select CLI operations in-process.
More can be done, but this is the first major step: running rustup-mode in-process much of the time.