Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustup doc does not use the BROWSER environment variable #1287

Closed
naufraghi opened this issue Nov 6, 2017 · 0 comments
Closed

rustup doc does not use the BROWSER environment variable #1287

naufraghi opened this issue Nov 6, 2017 · 0 comments

Comments

@naufraghi
Copy link
Contributor

naufraghi commented Nov 6, 2017 •
edited
Loading

I noted that rustup doc has an hardcoded list of commands to fire up a browser, but I discovered from the webbrowser.py sources that the user can set the BROWSER environment variable to override the command.

I find this very useful, because I usually have more than one open browser and sometime I prefer to open the documentation in a browser that is not the system default one.

I have a mostly working patch for this issue but my rust-foo is poor (very poor when strings come in) and the code is not something I'm very proud of.

If the feature is something someone else is interested in, I can open a PR for further review.
@naufraghi naufraghi mentioned this issue Nov 6, 2017
Closed
naufraghi added a commit to naufraghi/rustup.rs that referenced this issue Nov 6, 2017
@naufraghi
Use browser in BROWSER env if present for doc command
e735538 
If the BROWSER enviroment variable is found, it is used as a list of
commands to be tested before the hardcoded ones to launch a browser.

Issue rust-lang#1287
@naufraghi naufraghi mentioned this issue Nov 6, 2017
Merged
@Diggsey Diggsey closed this as completed May 30, 2018
@jer-irl jer-irl mentioned this issue Jan 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@naufraghi @Diggsey