Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update enums3.rs #560

Closed
wants to merge 2 commits into from
Closed

Update enums3.rs #560

wants to merge 2 commits into from

Conversation

fpolica91
Copy link

This will cause the function to keep failing, In order to pass I needed to remove a pair of quotes, not sure if this was intentional and my solution was wrong, but this was the only solution I was able to come up with.

This will cause the function to keep failing, In order to pass I needed to remove a pair of quotes, not sure if this was intentional and my solution was wrong, but this was the only solution I was able to come up with.
@darnuria
Copy link
Contributor

darnuria commented Oct 13, 2020

@fpolica91 hi! Thanks for your submission!

In this exercise I think the point is to write out an enum Message with changing as little as possible where the code is already written.

Did you consider using a (u8, u8, u8) for Message::Color?

Right now in your file I wonders you wrote in Message Color(u8, u8, u8). It's not the same as Color((u8, u8, u8)),
These change might need to change your implementation in fn process.

But I also agree that it's not really clear and it's subtle in a beginner journey to see the difference to from the two types. So I think there is matter to discuss! And maybe change the subject if it's too unclear. :D

@shadows-withal
Copy link
Member

This is a partial duplicate of #561, and vice-versa.

@darnuria
Copy link
Contributor

darnuria commented Oct 14, 2020

@fmoko wanted to say #537 I think. :D

[edit; I think it's time to sleep mis typed PR number twice]

@shadows-withal
Copy link
Member

you're right haha

@shadows-withal
Copy link
Member

Closing along with #537.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants