Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added option exercise #282

Merged
merged 6 commits into from
Apr 5, 2020
Merged

feat: added option exercise #282

merged 6 commits into from
Apr 5, 2020

Conversation

sanjaykdragon
Copy link
Contributor

I have added a basic Option exercise. I plan to add more exercises if this gets accepted. Let me know what to fix / change. I copied some formatting stuff from other exercises.

@sanjaykdragon
Copy link
Contributor Author

@fmoko

@shadows-withal shadows-withal self-requested a review March 6, 2020 13:36
Copy link
Member

@shadows-withal shadows-withal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I have a couple of questions and suggestions.

exercises/option/option1.rs Outdated Show resolved Hide resolved
exercises/option/option1.rs Outdated Show resolved Hide resolved
info.toml Outdated Show resolved Hide resolved
@sanjaykdragon
Copy link
Contributor Author

Also just fixed some stupid mistakes I made.

@shadows-withal
Copy link
Member

Once you reorder the exercise in info.toml, I'm ready to merge this!

@sanjaykdragon
Copy link
Contributor Author

Once you reorder the exercise in info.toml, I'm ready to merge this!

Updated

@shadows-withal
Copy link
Member

Thanks a bunch!

@shadows-withal shadows-withal merged commit 7ce4294 into rust-lang:master Apr 5, 2020
ppp3 pushed a commit to ppp3/rustlings that referenced this pull request May 23, 2022
dmoore04 pushed a commit to dmoore04/rustlings that referenced this pull request Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants