Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors6: Add alternative solution using From trait #2158

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

mnshdw
Copy link
Contributor

@mnshdw mnshdw commented Nov 13, 2024

Discussed in #2157

Let me know if you think this should be reworded or something else should be added.

Thanks!

@mnshdw mnshdw mentioned this pull request Nov 13, 2024
@mo8it
Copy link
Contributor

mo8it commented Nov 13, 2024

Awesome, thanks!

Could you please replace /// with // for the comments? Then I will merge :)

@mnshdw
Copy link
Contributor Author

mnshdw commented Nov 14, 2024

Done.

@mo8it mo8it merged commit dd0634c into rust-lang:main Nov 14, 2024
7 checks passed
glpuga added a commit to glpuga/rustlings that referenced this pull request Nov 19, 2024
glpuga added a commit to glpuga/rustlings that referenced this pull request Nov 19, 2024
@mnshdw mnshdw deleted the mnshdw/feedback-errors6 branch November 28, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants